Skip to content

Remove dead code in preparation for read replicas#7612

Open
Sovietaced wants to merge 2 commits into
flyteorg:masterfrom
Sovietaced:read-replica-prep
Open

Remove dead code in preparation for read replicas#7612
Sovietaced wants to merge 2 commits into
flyteorg:masterfrom
Sovietaced:read-replica-prep

Conversation

@Sovietaced

@Sovietaced Sovietaced commented Jul 1, 2026

Copy link
Copy Markdown
Member

Tracking issue

Why are the changes needed?

Dead code is confusing when trying to understand the codebase

What changes were proposed in this pull request?

Removed dead code under flytestdlib/database

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@github-actions github-actions Bot added the flyte label Jul 1, 2026
@Sovietaced Sovietaced marked this pull request as ready for review July 1, 2026 20:30
@Sovietaced Sovietaced added the removed For features being removed label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.14%. Comparing base (de65211) to head (8b7a200).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7612      +/-   ##
==========================================
- Coverage   57.16%   57.14%   -0.02%     
==========================================
  Files         925      930       +5     
  Lines       57823    58238     +415     
==========================================
+ Hits        33052    33280     +228     
- Misses      21753    21899     +146     
- Partials     3018     3059      +41     
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.15% <ø> (+0.03%) ⬆️
unittests-flytecopilot 43.06% <ø> (?)
unittests-flytectl 64.09% <ø> (ø)
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.36% <ø> (ø)
unittests-flytepropeller 53.78% <ø> (ø)
unittests-flytestdlib 64.41% <ø> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pingsutw
pingsutw previously approved these changes Jul 1, 2026
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flyte removed For features being removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants